From: Krzysztof Kozlowski Date: Sun, 25 Jun 2023 16:28:04 +0000 (+0200) Subject: Input: ektf2127 - simplify with dev_err_probe() X-Git-Tag: v6.6.7~1735^2~8^2~61 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=d9efc285f75e7f6028ff3b87f0169a0decfdc36b;p=platform%2Fkernel%2Flinux-starfive.git Input: ektf2127 - simplify with dev_err_probe() Common pattern of handling deferred probe can be simplified with dev_err_probe(). Less code and also it prints the error value. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Hans de Goede Reviewed-by: Andy Shevchenko Link: https://lore.kernel.org/r/20230625162817.100397-12-krzysztof.kozlowski@linaro.org Signed-off-by: Dmitry Torokhov --- diff --git a/drivers/input/touchscreen/ektf2127.c b/drivers/input/touchscreen/ektf2127.c index fd8724a..cc3103b 100644 --- a/drivers/input/touchscreen/ektf2127.c +++ b/drivers/input/touchscreen/ektf2127.c @@ -264,12 +264,8 @@ static int ektf2127_probe(struct i2c_client *client) /* This requests the gpio *and* turns on the touchscreen controller */ ts->power_gpios = devm_gpiod_get(dev, "power", GPIOD_OUT_HIGH); - if (IS_ERR(ts->power_gpios)) { - error = PTR_ERR(ts->power_gpios); - if (error != -EPROBE_DEFER) - dev_err(dev, "Error getting power gpio: %d\n", error); - return error; - } + if (IS_ERR(ts->power_gpios)) + return dev_err_probe(dev, PTR_ERR(ts->power_gpios), "Error getting power gpio\n"); input = devm_input_allocate_device(dev); if (!input)