From: Barry Song Date: Tue, 27 Oct 2020 21:52:49 +0000 (+1300) Subject: dmaengine: hisi_dma: remove redundant irqsave and irqrestore in hardIRQ X-Git-Tag: accepted/tizen/unified/20230118.172025~8231^2~52 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=d9c8d4b278d167bf7cba83ec6fc15a0a17dfc407;p=platform%2Fkernel%2Flinux-rpi.git dmaengine: hisi_dma: remove redundant irqsave and irqrestore in hardIRQ Running in hardIRQ, disabling IRQ is redundant since hardIRQ has disabled IRQ. This patch removes the irqsave and irqstore to save some instruction cycles. Signed-off-by: Barry Song Acked-by: Zhou Wang Link: https://lore.kernel.org/r/20201027215252.25820-8-song.bao.hua@hisilicon.com Signed-off-by: Vinod Koul --- diff --git a/drivers/dma/hisi_dma.c b/drivers/dma/hisi_dma.c index e1a958a..a259ee0 100644 --- a/drivers/dma/hisi_dma.c +++ b/drivers/dma/hisi_dma.c @@ -431,9 +431,8 @@ static irqreturn_t hisi_dma_irq(int irq, void *data) struct hisi_dma_dev *hdma_dev = chan->hdma_dev; struct hisi_dma_desc *desc; struct hisi_dma_cqe *cqe; - unsigned long flags; - spin_lock_irqsave(&chan->vc.lock, flags); + spin_lock(&chan->vc.lock); desc = chan->desc; cqe = chan->cq + chan->cq_head; @@ -452,7 +451,7 @@ static irqreturn_t hisi_dma_irq(int irq, void *data) chan->desc = NULL; } - spin_unlock_irqrestore(&chan->vc.lock, flags); + spin_unlock(&chan->vc.lock); return IRQ_HANDLED; }