From: David Kershner <david.kershner@unisys.com>
Date: Tue, 18 Apr 2017 20:55:21 +0000 (-0400)
Subject: staging: unisys: visorbus: refactor setup_crash_devices_work_queue
X-Git-Tag: v4.14-rc1~980^2~58
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=d9b89ef189a876a37032b8cc1fea4a80018d371d;p=platform%2Fkernel%2Flinux-rpi.git

staging: unisys: visorbus: refactor setup_crash_devices_work_queue

The if statement was sending us down the happy path with the error path
in the else. This can be simplified by having the if be the error and
just falling through with the good path.

Signed-off-by: David Kershner <david.kershner@unisys.com>
Reviewed-by: Tim Sell <timothy.sell@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/staging/unisys/visorbus/visorchipset.c b/drivers/staging/unisys/visorbus/visorchipset.c
index 6fc8980..ec8fc0b 100644
--- a/drivers/staging/unisys/visorbus/visorchipset.c
+++ b/drivers/staging/unisys/visorbus/visorchipset.c
@@ -1431,22 +1431,21 @@ setup_crash_devices_work_queue(struct work_struct *work)
 	}
 
 	/* reuse IOVM create bus message */
-	if (local_crash_bus_msg.cmd.create_bus.channel_addr) {
-		bus_create(&local_crash_bus_msg);
-	} else {
+	if (!local_crash_bus_msg.cmd.create_bus.channel_addr) {
 		POSTCODE_LINUX(CRASH_DEV_BUS_NULL_FAILURE_PC, 0, 0,
 			       DIAG_SEVERITY_ERR);
 		return;
 	}
+	bus_create(&local_crash_bus_msg);
 
 	/* reuse create device message for storage device */
-	if (local_crash_dev_msg.cmd.create_device.channel_addr) {
-		my_device_create(&local_crash_dev_msg);
-	} else {
+	if (!local_crash_dev_msg.cmd.create_device.channel_addr) {
 		POSTCODE_LINUX(CRASH_DEV_DEV_NULL_FAILURE_PC, 0, 0,
 			       DIAG_SEVERITY_ERR);
 		return;
 	}
+	my_device_create(&local_crash_dev_msg);
+
 	POSTCODE_LINUX(CRASH_DEV_EXIT_PC, 0, 0, DIAG_SEVERITY_PRINT);
 }