From: Kim, Milo Date: Fri, 27 Apr 2012 05:01:10 +0000 (-0700) Subject: staging: android: timed_output : disable the timed output device when the device... X-Git-Tag: v3.5-rc1~145^2~229^2~42 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=d9a861d55e0cf60829956d7c6e18b7de0b02ab92;p=profile%2Fivi%2Fkernel-x86-ivi.git staging: android: timed_output : disable the timed output device when the device is unregistered (Life cycle of timed output device driver) 1) register the device as the timed output 2) enable() ops is called via the sysfs timeout > 0 : timer is activated and device is turned on timeout = 0 : timer is cancelled and device is off 3) unregister the timed output device if not used any more So the registered device should be disabled explicitly when the module is removed. ('disabled' means the timer is stopped and the device is turned off) Rather than implementing that code in each driver, just call enable() with timeout = 0 to clean up the driver. Signed-off-by: Milo(Woogyom) Kim Cc: Mike Lockwood Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/android/timed_output.c b/drivers/staging/android/timed_output.c index f373422308e..38d930cadad 100644 --- a/drivers/staging/android/timed_output.c +++ b/drivers/staging/android/timed_output.c @@ -99,6 +99,7 @@ EXPORT_SYMBOL_GPL(timed_output_dev_register); void timed_output_dev_unregister(struct timed_output_dev *tdev) { + tdev->enable(tdev, 0); device_remove_file(tdev->dev, &dev_attr_enable); device_destroy(timed_output_class, MKDEV(0, tdev->index)); dev_set_drvdata(tdev->dev, NULL);