From: Antoni Adaszkiewicz <a.adaszkiewi@samsung.com>
Date: Tue, 10 Jan 2023 12:32:45 +0000 (+0100)
Subject: upgrade-apply-deltafs: Fix missleading debug message in SS_Unlink()
X-Git-Tag: accepted/tizen/unified/20230116.060918^0
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=d992f167adc0b004305be1b056753e00f66eafb6;p=platform%2Fcore%2Fsystem%2Fupgrade.git

upgrade-apply-deltafs: Fix missleading debug message in SS_Unlink()

ENOENT is handled by upgrade-apply-deltafs, but previous debug
messages suggested that ENOENT was an error.

Change-Id: I272886ee2f66d4efb0ee64b13af018c98b6362a2
---

diff --git a/src/upgrade-apply-deltafs/engine/SS_FSUpdate.c b/src/upgrade-apply-deltafs/engine/SS_FSUpdate.c
index 54ff219..c87205d 100755
--- a/src/upgrade-apply-deltafs/engine/SS_FSUpdate.c
+++ b/src/upgrade-apply-deltafs/engine/SS_FSUpdate.c
@@ -521,11 +521,15 @@ long SS_Unlink(char *pLinkName)
 	SS_unicode_to_char((const char *)pLinkName, (char *)path, MAX_PATH - 1);
 
 	ret = unlink(path);
-	if (ret < 0 && errno != ENOENT) {
-		LOGE("unlink failed with return value: %d\n", ret);
-		return E_SS_FAILURE;
+	if (ret < 0) {
+		if (errno != ENOENT) {
+			LOGE("unlink failed with return value: %d\n", ret);
+			return E_SS_FAILURE;
+		}
+		LOGL(LOG_SSENGINE, "unlink with return value: %d, but errno is ENOENT and is expected\n", ret);
+	} else {
+		LOGL(LOG_SSENGINE, "unlink with return value: %d\n", ret);
 	}
-	LOGL(LOG_SSENGINE, "unlink with return value: %d\n", ret);
 
 	return S_SS_SUCCESS;
 }