From: Daniel Scheller Date: Sat, 23 Jun 2018 15:36:01 +0000 (-0400) Subject: media: ddbridge: report I2C bus errors X-Git-Tag: v5.15~8227^2~114 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=d96eeee502cc5c75e0ab7d61468a3b906e609e98;p=platform%2Fkernel%2Flinux-starfive.git media: ddbridge: report I2C bus errors The I2C_COMMAND response reports an error in the I2C bus communication using bit 17. Evaluate the response more thoroughly and log an error if an I2C problem was detected. Picked up from the upstream dddvb GIT. Signed-off-by: Daniel Scheller Signed-off-by: Mauro Carvalho Chehab --- diff --git a/drivers/media/pci/ddbridge/ddbridge-i2c.c b/drivers/media/pci/ddbridge/ddbridge-i2c.c index 667340c..5a28d76 100644 --- a/drivers/media/pci/ddbridge/ddbridge-i2c.c +++ b/drivers/media/pci/ddbridge/ddbridge-i2c.c @@ -73,7 +73,10 @@ static int ddb_i2c_cmd(struct ddb_i2c *i2c, u32 adr, u32 cmd) } return -EIO; } - if (val & 0x70000) + val &= 0x70000; + if (val == 0x20000) + dev_err(dev->dev, "I2C bus error\n"); + if (val) return -EIO; return 0; }