From: Dan Carpenter Date: Fri, 13 Sep 2013 07:52:49 +0000 (+0300) Subject: ASoC: 88pm860x: array overflow in snd_soc_put_volsw_2r_st() X-Git-Tag: upstream/snapshot3+hdmi~4072^2~20^2~5^2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=d967967e8d1116fb38bad25e58714b5dddd03cca;p=platform%2Fadaptation%2Frenesas_rcar%2Frenesas_kernel.git ASoC: 88pm860x: array overflow in snd_soc_put_volsw_2r_st() This is called from snd_ctl_elem_write() with user supplied data so we need to add some bounds checking. Signed-off-by: Dan Carpenter Signed-off-by: Mark Brown Cc: stable@vger.kernel.org --- diff --git a/sound/soc/codecs/88pm860x-codec.c b/sound/soc/codecs/88pm860x-codec.c index 8af0434..259d1ac 100644 --- a/sound/soc/codecs/88pm860x-codec.c +++ b/sound/soc/codecs/88pm860x-codec.c @@ -349,6 +349,9 @@ static int snd_soc_put_volsw_2r_st(struct snd_kcontrol *kcontrol, val = ucontrol->value.integer.value[0]; val2 = ucontrol->value.integer.value[1]; + if (val >= ARRAY_SIZE(st_table) || val2 >= ARRAY_SIZE(st_table)) + return -EINVAL; + err = snd_soc_update_bits(codec, reg, 0x3f, st_table[val].m); if (err < 0) return err;