From: Tom Tromey <tom@tromey.com>
Date: Sun, 22 Apr 2018 16:46:03 +0000 (-0600)
Subject: Shadowing fix in gdbscm_frame_read_var
X-Git-Tag: users/ARM/embedded-binutils-master-2018q4~510
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=d951f98b3c8bf202571327d8679ae30ca1da9fdc;p=platform%2Fupstream%2Fbinutils.git

Shadowing fix in gdbscm_frame_read_var

-Wshadow=local pointed out that the shadowing in gdbscm_frame_read_var
means that the ultimate call to read_var_value will always be passed
block==NULL.  The fix is to remove the inner declaration.

gdb/ChangeLog
2018-10-04  Tom Tromey  <tom@tromey.com>

	* guile/scm-frame.c (gdbscm_frame_read_var): Remove inner
	declaration of "block".
---

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 42c55ed..3bf08bc 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,10 @@
 2018-10-04  Tom Tromey  <tom@tromey.com>
 
+	* guile/scm-frame.c (gdbscm_frame_read_var): Remove inner
+	declaration of "block".
+
+2018-10-04  Tom Tromey  <tom@tromey.com>
+
 	* common/filestuff.c (fdwalk): Remove inner declaration of
 	"result".
 
diff --git a/gdb/guile/scm-frame.c b/gdb/guile/scm-frame.c
index 3d27907e..5a056de 100644
--- a/gdb/guile/scm-frame.c
+++ b/gdb/guile/scm-frame.c
@@ -878,7 +878,6 @@ gdbscm_frame_read_var (SCM self, SCM symbol_scm, SCM rest)
     }
   else if (scm_is_string (symbol_scm))
     {
-      const struct block *block = NULL;
       struct gdb_exception except = exception_none;
 
       if (! SCM_UNBNDP (block_scm))