From: driazati Date: Tue, 24 Aug 2021 00:30:51 +0000 (-0700) Subject: Skip archiving useless build artifacts (#63785) X-Git-Tag: accepted/tizen/8.0/unified/20231005.095509~799 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=d9231dc3dfb9c218bbd62355f9a0349be2ceca75;p=platform%2Fupstream%2Fpytorch.git Skip archiving useless build artifacts (#63785) Summary: Pull Request resolved: https://github.com/pytorch/pytorch/pull/63785 We currently zip up everything in `build/` which includes a lot of cruft (`.o` files, random things copied in from dependencies, etc). This makes the artifact bigger (slower upload/download times, and takes about 1.5 minutes to archive). This change makes archiving instead take ~15 seconds and removes the 50 second upload to GitHub step that isn't as useful now that we have the HUD PR page that lists out all artifacts. Test Plan: Imported from OSS Reviewed By: seemethere, janeyx99 Differential Revision: D30494444 Pulled By: driazati fbshipit-source-id: 93202dba7387daeb4859a938110b02ff2dc2ccc4 --- diff --git a/.github/templates/linux_ci_workflow.yml.j2 b/.github/templates/linux_ci_workflow.yml.j2 index 25099b4..767760b 100644 --- a/.github/templates/linux_ci_workflow.yml.j2 +++ b/.github/templates/linux_ci_workflow.yml.j2 @@ -220,18 +220,7 @@ jobs: {%- if not is_libtorch %} - name: Archive artifacts into zip run: | - zip -r artifacts.zip dist/ build/ .pytorch-test-times.json - # Upload to github so that people can click and download artifacts - - uses: actions/upload-artifact@v2 - # Don't fail on upload to GH since it's only for user convenience - continue-on-error: true - name: Store PyTorch Build Artifacts on Github - with: - name: ${{ env.BUILD_ENVIRONMENT }} - retention-days: 14 - if-no-files-found: error - path: - artifacts.zip + zip -1 -r artifacts.zip dist/ build/custom_test_artifacts build/lib build/bin .pytorch-test-times.json - uses: seemethere/upload-artifact-s3@9d7ceb0ab39c2c88d93ef7792b27425b27d59162 name: Store PyTorch Build Artifacts on S3 with: diff --git a/.github/workflows/generated-linux-bionic-cuda10.2-py3.9-gcc7.yml b/.github/workflows/generated-linux-bionic-cuda10.2-py3.9-gcc7.yml index 67bb206..61a817e 100644 --- a/.github/workflows/generated-linux-bionic-cuda10.2-py3.9-gcc7.yml +++ b/.github/workflows/generated-linux-bionic-cuda10.2-py3.9-gcc7.yml @@ -199,18 +199,7 @@ jobs: docker run --rm -v "$(pwd)":/v -w /v "${ALPINE_IMAGE}" chown -R "$(id -u):$(id -g)" . - name: Archive artifacts into zip run: | - zip -r artifacts.zip dist/ build/ .pytorch-test-times.json - # Upload to github so that people can click and download artifacts - - uses: actions/upload-artifact@v2 - # Don't fail on upload to GH since it's only for user convenience - continue-on-error: true - name: Store PyTorch Build Artifacts on Github - with: - name: ${{ env.BUILD_ENVIRONMENT }} - retention-days: 14 - if-no-files-found: error - path: - artifacts.zip + zip -1 -r artifacts.zip dist/ build/custom_test_artifacts build/lib build/bin .pytorch-test-times.json - uses: seemethere/upload-artifact-s3@9d7ceb0ab39c2c88d93ef7792b27425b27d59162 name: Store PyTorch Build Artifacts on S3 with: diff --git a/.github/workflows/generated-linux-bionic-py3.8-gcc9-coverage.yml b/.github/workflows/generated-linux-bionic-py3.8-gcc9-coverage.yml index 5906166..f07b871 100644 --- a/.github/workflows/generated-linux-bionic-py3.8-gcc9-coverage.yml +++ b/.github/workflows/generated-linux-bionic-py3.8-gcc9-coverage.yml @@ -199,18 +199,7 @@ jobs: docker run --rm -v "$(pwd)":/v -w /v "${ALPINE_IMAGE}" chown -R "$(id -u):$(id -g)" . - name: Archive artifacts into zip run: | - zip -r artifacts.zip dist/ build/ .pytorch-test-times.json - # Upload to github so that people can click and download artifacts - - uses: actions/upload-artifact@v2 - # Don't fail on upload to GH since it's only for user convenience - continue-on-error: true - name: Store PyTorch Build Artifacts on Github - with: - name: ${{ env.BUILD_ENVIRONMENT }} - retention-days: 14 - if-no-files-found: error - path: - artifacts.zip + zip -1 -r artifacts.zip dist/ build/custom_test_artifacts build/lib build/bin .pytorch-test-times.json - uses: seemethere/upload-artifact-s3@9d7ceb0ab39c2c88d93ef7792b27425b27d59162 name: Store PyTorch Build Artifacts on S3 with: diff --git a/.github/workflows/generated-linux-xenial-cuda10.2-py3.6-gcc7.yml b/.github/workflows/generated-linux-xenial-cuda10.2-py3.6-gcc7.yml index d897e28..cb8c6b5 100644 --- a/.github/workflows/generated-linux-xenial-cuda10.2-py3.6-gcc7.yml +++ b/.github/workflows/generated-linux-xenial-cuda10.2-py3.6-gcc7.yml @@ -199,18 +199,7 @@ jobs: docker run --rm -v "$(pwd)":/v -w /v "${ALPINE_IMAGE}" chown -R "$(id -u):$(id -g)" . - name: Archive artifacts into zip run: | - zip -r artifacts.zip dist/ build/ .pytorch-test-times.json - # Upload to github so that people can click and download artifacts - - uses: actions/upload-artifact@v2 - # Don't fail on upload to GH since it's only for user convenience - continue-on-error: true - name: Store PyTorch Build Artifacts on Github - with: - name: ${{ env.BUILD_ENVIRONMENT }} - retention-days: 14 - if-no-files-found: error - path: - artifacts.zip + zip -1 -r artifacts.zip dist/ build/custom_test_artifacts build/lib build/bin .pytorch-test-times.json - uses: seemethere/upload-artifact-s3@9d7ceb0ab39c2c88d93ef7792b27425b27d59162 name: Store PyTorch Build Artifacts on S3 with: diff --git a/.github/workflows/generated-linux-xenial-cuda11.1-py3.6-gcc7.yml b/.github/workflows/generated-linux-xenial-cuda11.1-py3.6-gcc7.yml index 30514ca..4275cc3 100644 --- a/.github/workflows/generated-linux-xenial-cuda11.1-py3.6-gcc7.yml +++ b/.github/workflows/generated-linux-xenial-cuda11.1-py3.6-gcc7.yml @@ -199,18 +199,7 @@ jobs: docker run --rm -v "$(pwd)":/v -w /v "${ALPINE_IMAGE}" chown -R "$(id -u):$(id -g)" . - name: Archive artifacts into zip run: | - zip -r artifacts.zip dist/ build/ .pytorch-test-times.json - # Upload to github so that people can click and download artifacts - - uses: actions/upload-artifact@v2 - # Don't fail on upload to GH since it's only for user convenience - continue-on-error: true - name: Store PyTorch Build Artifacts on Github - with: - name: ${{ env.BUILD_ENVIRONMENT }} - retention-days: 14 - if-no-files-found: error - path: - artifacts.zip + zip -1 -r artifacts.zip dist/ build/custom_test_artifacts build/lib build/bin .pytorch-test-times.json - uses: seemethere/upload-artifact-s3@9d7ceb0ab39c2c88d93ef7792b27425b27d59162 name: Store PyTorch Build Artifacts on S3 with: diff --git a/.github/workflows/generated-linux-xenial-py3.6-gcc5.4.yml b/.github/workflows/generated-linux-xenial-py3.6-gcc5.4.yml index bd4d650..e3be433 100644 --- a/.github/workflows/generated-linux-xenial-py3.6-gcc5.4.yml +++ b/.github/workflows/generated-linux-xenial-py3.6-gcc5.4.yml @@ -199,18 +199,7 @@ jobs: docker run --rm -v "$(pwd)":/v -w /v "${ALPINE_IMAGE}" chown -R "$(id -u):$(id -g)" . - name: Archive artifacts into zip run: | - zip -r artifacts.zip dist/ build/ .pytorch-test-times.json - # Upload to github so that people can click and download artifacts - - uses: actions/upload-artifact@v2 - # Don't fail on upload to GH since it's only for user convenience - continue-on-error: true - name: Store PyTorch Build Artifacts on Github - with: - name: ${{ env.BUILD_ENVIRONMENT }} - retention-days: 14 - if-no-files-found: error - path: - artifacts.zip + zip -1 -r artifacts.zip dist/ build/custom_test_artifacts build/lib build/bin .pytorch-test-times.json - uses: seemethere/upload-artifact-s3@9d7ceb0ab39c2c88d93ef7792b27425b27d59162 name: Store PyTorch Build Artifacts on S3 with: diff --git a/.github/workflows/generated-periodic-linux-xenial-cuda11.3-py3.6-gcc7.yml b/.github/workflows/generated-periodic-linux-xenial-cuda11.3-py3.6-gcc7.yml index 5fd0e99..0282b20 100644 --- a/.github/workflows/generated-periodic-linux-xenial-cuda11.3-py3.6-gcc7.yml +++ b/.github/workflows/generated-periodic-linux-xenial-cuda11.3-py3.6-gcc7.yml @@ -197,18 +197,7 @@ jobs: docker run --rm -v "$(pwd)":/v -w /v "${ALPINE_IMAGE}" chown -R "$(id -u):$(id -g)" . - name: Archive artifacts into zip run: | - zip -r artifacts.zip dist/ build/ .pytorch-test-times.json - # Upload to github so that people can click and download artifacts - - uses: actions/upload-artifact@v2 - # Don't fail on upload to GH since it's only for user convenience - continue-on-error: true - name: Store PyTorch Build Artifacts on Github - with: - name: ${{ env.BUILD_ENVIRONMENT }} - retention-days: 14 - if-no-files-found: error - path: - artifacts.zip + zip -1 -r artifacts.zip dist/ build/custom_test_artifacts build/lib build/bin .pytorch-test-times.json - uses: seemethere/upload-artifact-s3@9d7ceb0ab39c2c88d93ef7792b27425b27d59162 name: Store PyTorch Build Artifacts on S3 with: