From: Dan Callaghan Date: Tue, 18 Oct 2022 23:52:37 +0000 (+1100) Subject: platform/chrome: cros_hps_i2c: make remove callback return void X-Git-Tag: v6.6.7~4016^2~13 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=d8cb88f1541fdc3602dbc87ede78ec704c11546f;p=platform%2Fkernel%2Flinux-starfive.git platform/chrome: cros_hps_i2c: make remove callback return void Commit ed5c2f5fd10d ("i2c: Make remove callback return void") changed the return type of the 'remove' callback to void, but this driver was originally written before that change landed. Update the remove callback to match. Fixes: 5f9952548d91 ("platform/chrome: add a driver for HPS") Reported-by: kernel test robot Signed-off-by: Dan Callaghan Signed-off-by: Tzung-Bi Shih Link: https://lore.kernel.org/r/20221018235237.2274969-1-dcallagh@chromium.org --- diff --git a/drivers/platform/chrome/cros_hps_i2c.c b/drivers/platform/chrome/cros_hps_i2c.c index 92da59d..62ccb1a 100644 --- a/drivers/platform/chrome/cros_hps_i2c.c +++ b/drivers/platform/chrome/cros_hps_i2c.c @@ -95,7 +95,7 @@ static int hps_i2c_probe(struct i2c_client *client) return 0; } -static int hps_i2c_remove(struct i2c_client *client) +static void hps_i2c_remove(struct i2c_client *client) { struct hps_drvdata *hps = i2c_get_clientdata(client); @@ -107,8 +107,6 @@ static int hps_i2c_remove(struct i2c_client *client) * (i.e. powered on). */ hps_set_power(hps, true); - - return 0; } static int hps_suspend(struct device *dev)