From: Fabio Estevam Date: Thu, 18 Jul 2013 18:07:48 +0000 (-0300) Subject: ASoC: fsl: imx-wm8962: Fix error path X-Git-Tag: v3.12-rc1~43^2~9^2~3^2~26 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=d8a14e302ffeecc312186b8b9b0efc8963cec83b;p=profile%2Fcommon%2Fkernel-common.git ASoC: fsl: imx-wm8962: Fix error path If the 'failed to find codec platform device' error path is executed, it should jump to 'fail' label instead of returning an error immediately. 'fail' label will then free the ssi_np and codec_np previously acquired nodes. Signed-off-by: Fabio Estevam Signed-off-by: Mark Brown --- diff --git a/sound/soc/fsl/imx-wm8962.c b/sound/soc/fsl/imx-wm8962.c index 52a36a9..1d70e27 100644 --- a/sound/soc/fsl/imx-wm8962.c +++ b/sound/soc/fsl/imx-wm8962.c @@ -217,7 +217,8 @@ static int imx_wm8962_probe(struct platform_device *pdev) codec_dev = of_find_i2c_device_by_node(codec_np); if (!codec_dev || !codec_dev->driver) { dev_err(&pdev->dev, "failed to find codec platform device\n"); - return -EINVAL; + ret = -EINVAL; + goto fail; } data = devm_kzalloc(&pdev->dev, sizeof(*data), GFP_KERNEL);