From: Dan Carpenter Date: Fri, 23 May 2014 16:37:21 +0000 (+0300) Subject: qlcnic: info leak in qlcnic_dcb_peer_app_info() X-Git-Tag: v3.12.23~19 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=d8981d30858dafaf3b603ffd2d1231f410821e29;p=platform%2Fkernel%2Flinux-stable.git qlcnic: info leak in qlcnic_dcb_peer_app_info() [ Upstream commit 7df566bbdd0af0785542b89466a937e94257fcfb ] This function is called from dcbnl_build_peer_app(). The "info" struct isn't initialized at all so we disclose 2 bytes of uninitialized stack data. We should clear it before passing it to the user. Fixes: 48365e485275 ('qlcnic: dcb: Add support for CEE Netlink interface.') Signed-off-by: Dan Carpenter Signed-off-by: David S. Miller Signed-off-by: Jiri Slaby --- diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_dcb.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_dcb.c index d62d5ce432ec..d677eabf3c1e 100644 --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_dcb.c +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_dcb.c @@ -1053,6 +1053,7 @@ static int qlcnic_dcb_peer_app_info(struct net_device *netdev, struct qlcnic_dcb_cee *peer; int i; + memset(info, 0, sizeof(*info)); *app_count = 0; if (!test_bit(__QLCNIC_DCB_STATE, &adapter->state))