From: Jim Kingdon <jkingdon@engr.sgi.com>
Date: Tue, 18 Jan 1994 04:29:34 +0000 (+0000)
Subject: 	* ser-unix.c (hardwire_noflush_set_tty_state): Don't muck with ICANON.
X-Git-Tag: gdb-4_18~15974
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=d881dd869fc70d807f3630328606c3d3cb3e83f9;p=platform%2Fupstream%2Fbinutils.git

	* ser-unix.c (hardwire_noflush_set_tty_state): Don't muck with ICANON.
	* inflow.c (terminal_ours_1): When discussing how to deal with the
	tty state, make note of query() as well as readline.
---

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index ab4270b..137fa16 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,9 @@
 Mon Jan 17 22:00:15 1994  Jim Kingdon  (kingdon@lioth.cygnus.com)
 
+	* ser-unix.c (hardwire_noflush_set_tty_state): Don't muck with ICANON.
+	* inflow.c (terminal_ours_1): When discussing how to deal with the
+	tty state, make note of query() as well as readline.
+
 	* infrun.c (_initialize_infrun): Add TARGET_SIGNAL_POLL to list of
 	signals for which stop and print are cleared by default.
 
diff --git a/gdb/ser-unix.c b/gdb/ser-unix.c
index 63207dd..d14a996 100644
--- a/gdb/ser-unix.c
+++ b/gdb/ser-unix.c
@@ -198,23 +198,9 @@ hardwire_noflush_set_tty_state (scb, new_ttystate, old_ttystate)
 
   new_state = *(struct hardwire_ttystate *)new_ttystate;
 
-#ifdef HAVE_TERMIOS
-  /* I'm not sure whether this is necessary; the manpage makes no mention
-     of discarding input when switching to/from ICANON.  */
-  if (state->termios.c_lflag & ICANON)
-    new_state.termios.c_lflag |= ICANON;
-  else
-    new_state.termios.c_lflag &= ~ICANON;
-#endif
-
-#ifdef HAVE_TERMIO
-  /* I'm not sure whether this is necessary; the manpage makes no mention
-     of discarding input when switching to/from ICANON.  */
-  if (state->termio.c_lflag & ICANON)
-    new_state.termio.c_lflag |= ICANON;
-  else
-    new_state.termio.c_lflag &= ~ICANON;
-#endif
+  /* Don't change in or out of raw mode; we don't want to flush input.
+     termio and termios have no such restriction; for them flushing input
+     is separate from setting the attributes.  */
 
 #ifdef HAVE_SGTTY
   if (state->sgttyb.sg_flags & RAW)