From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Tue, 2 Oct 2012 08:22:48 +0000 (+0300)
Subject: target/iscsi: precedence bug in iscsit_set_dataout_sequence_values()
X-Git-Tag: v3.7-rc1~61^2~6
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=d7ca663c775bd1aafb718bdd6c208b49a9d53f50;p=profile%2Fivi%2Fkernel-x86-ivi.git

target/iscsi: precedence bug in iscsit_set_dataout_sequence_values()

Clang warns about this bug:
drivers/target/iscsi/iscsi_target_erl0.c:52:45: warning: operator '?:'
	has lower precedence than '+'; '+' will be evaluated first
	[-Wparentheses]

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
---

diff --git a/drivers/target/iscsi/iscsi_target_erl0.c b/drivers/target/iscsi/iscsi_target_erl0.c
index 1a02016..2067efd 100644
--- a/drivers/target/iscsi/iscsi_target_erl0.c
+++ b/drivers/target/iscsi/iscsi_target_erl0.c
@@ -48,9 +48,9 @@ void iscsit_set_dataout_sequence_values(
 	if (cmd->unsolicited_data) {
 		cmd->seq_start_offset = cmd->write_data_done;
 		cmd->seq_end_offset = (cmd->write_data_done +
-			(cmd->se_cmd.data_length >
-			 conn->sess->sess_ops->FirstBurstLength) ?
-			conn->sess->sess_ops->FirstBurstLength : cmd->se_cmd.data_length);
+			((cmd->se_cmd.data_length >
+			  conn->sess->sess_ops->FirstBurstLength) ?
+			 conn->sess->sess_ops->FirstBurstLength : cmd->se_cmd.data_length));
 		return;
 	}