From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Date: Thu, 23 May 2013 09:32:14 +0000 (+0800)
Subject: pinctrl: sunxi: fix error return code in sunxi_pinctrl_probe()
X-Git-Tag: accepted/tizen/common/20141203.182822~2159^2~1
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=d72f88a42bf9761e3a92e58879d25a65712ca87a;p=platform%2Fkernel%2Flinux-arm64.git

pinctrl: sunxi: fix error return code in sunxi_pinctrl_probe()

Fix to return a negative error code from the devm_clk_get() error
handling case instead of 0, as done elsewhere in this function.

Introduced by commit 950707c0eb5c7aeaa2c446a04c824f4be686d2f6
(pinctrl: sunxi: add clock support)

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---

diff --git a/drivers/pinctrl/pinctrl-sunxi.c b/drivers/pinctrl/pinctrl-sunxi.c
index c058529..b7d8c89 100644
--- a/drivers/pinctrl/pinctrl-sunxi.c
+++ b/drivers/pinctrl/pinctrl-sunxi.c
@@ -1990,8 +1990,10 @@ static int sunxi_pinctrl_probe(struct platform_device *pdev)
 	}
 
 	clk = devm_clk_get(&pdev->dev, NULL);
-	if (IS_ERR(clk))
+	if (IS_ERR(clk)) {
+		ret = PTR_ERR(clk);
 		goto gpiochip_error;
+	}
 
 	clk_prepare_enable(clk);