From: Gao Xiang Date: Wed, 22 Sep 2021 09:51:41 +0000 (+0800) Subject: erofs: fix misbehavior of unsupported chunk format check X-Git-Tag: accepted/tizen/unified/20230118.172025~6284^2~1 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=d705117ddd724a9d4877e338e4587010ab6a1c62;p=platform%2Fkernel%2Flinux-rpi.git erofs: fix misbehavior of unsupported chunk format check Unsupported chunk format should be checked with "if (vi->chunkformat & ~EROFS_CHUNK_FORMAT_ALL)" Found when checking with 4k-byte blockmap (although currently mkfs uses inode chunk indexes format by default.) Link: https://lore.kernel.org/r/20210922095141.233938-1-hsiangkao@linux.alibaba.com Fixes: c5aa903a59db ("erofs: support reading chunk-based uncompressed files") Reviewed-by: Liu Bo Reviewed-by: Chao Yu Signed-off-by: Gao Xiang --- diff --git a/fs/erofs/inode.c b/fs/erofs/inode.c index 31ac3a7..a552399 100644 --- a/fs/erofs/inode.c +++ b/fs/erofs/inode.c @@ -176,7 +176,7 @@ static struct page *erofs_read_inode(struct inode *inode, } if (vi->datalayout == EROFS_INODE_CHUNK_BASED) { - if (!(vi->chunkformat & EROFS_CHUNK_FORMAT_ALL)) { + if (vi->chunkformat & ~EROFS_CHUNK_FORMAT_ALL) { erofs_err(inode->i_sb, "unsupported chunk format %x of nid %llu", vi->chunkformat, vi->nid);