From: Alexey Khoroshilov <khoroshilov@ispras.ru>
Date: Sun, 30 Dec 2018 11:41:40 +0000 (-0500)
Subject: media: tw9910: fix failure handling in tw9910_power_on()
X-Git-Tag: v5.4-rc1~1453^2~317
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=d6b10dd0017641fee31daa84e478708a33d2f00a;p=platform%2Fkernel%2Flinux-rpi.git

media: tw9910: fix failure handling in tw9910_power_on()

If gpiod_get_optional() fails in tw9910_power_on(), clk is left undisabled.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
---

diff --git a/drivers/media/i2c/tw9910.c b/drivers/media/i2c/tw9910.c
index a54548cc..0971f8a 100644
--- a/drivers/media/i2c/tw9910.c
+++ b/drivers/media/i2c/tw9910.c
@@ -610,6 +610,11 @@ static int tw9910_power_on(struct tw9910_priv *priv)
 					     GPIOD_OUT_LOW);
 	if (IS_ERR(priv->rstb_gpio)) {
 		dev_info(&client->dev, "Unable to get GPIO \"rstb\"");
+		clk_disable_unprepare(priv->clk);
+		if (priv->pdn_gpio) {
+			gpiod_set_value(priv->pdn_gpio, 1);
+			usleep_range(500, 1000);
+		}
 		return PTR_ERR(priv->rstb_gpio);
 	}