From: Jiyong Date: Tue, 5 Mar 2024 04:29:04 +0000 (+0900) Subject: Fix coverity issue (RESOURCE_LEAK) X-Git-Tag: accepted/tizen/unified/20240306.094106^0 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=d6ac52168aeaac7008395a51c5ddce88335a0072;p=platform%2Fcore%2Fmultimedia%2Flibmm-utility.git Fix coverity issue (RESOURCE_LEAK) - Variable '_module' leaks the storage when 'module' is null Change-Id: I7ddc9e1c70a0fedddf417fc823bd4a021955237c --- diff --git a/imgp/mm_util_imgp.c b/imgp/mm_util_imgp.c index fc3f9b0..4456655 100644 --- a/imgp/mm_util_imgp.c +++ b/imgp/mm_util_imgp.c @@ -279,8 +279,10 @@ static IMGPInfoFunc __mm_util_initialize(void **module) void *_module = NULL; IMGPInfoFunc _func = NULL; + mm_util_retvm_if(!module, NULL, "invalid module"); + _module = dlopen(PATH_GSTCS_LIB, RTLD_LAZY); - mm_util_retvm_if(!module, NULL, "%s module open failed", PATH_GSTCS_LIB); + mm_util_retvm_if(!_module, NULL, "%s module open failed", PATH_GSTCS_LIB); _func = dlsym(_module, IMGP_FUNC_NAME); if (!_func) { diff --git a/packaging/libmm-utility.spec b/packaging/libmm-utility.spec index ae6db70..7d9b07b 100644 --- a/packaging/libmm-utility.spec +++ b/packaging/libmm-utility.spec @@ -1,6 +1,6 @@ Name: libmm-utility Summary: Multimedia Framework Utility Library -Version: 0.4.17 +Version: 0.4.18 Release: 0 Group: System/Libraries License: Apache-2.0