From: Courtney Goeltzenleuchter <courtneygo@google.com>
Date: Thu, 14 Jan 2016 23:06:06 +0000 (-0700)
Subject: loader: remove resolved TODOs
X-Git-Tag: upstream/1.1.92~4059
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=d67187f62af471d76ec973c6357b1abe6d96c5f3;p=platform%2Fupstream%2FVulkan-Tools.git

loader: remove resolved TODOs
---

diff --git a/loader/loader.c b/loader/loader.c
index 8c89651..2f253f0 100644
--- a/loader/loader.c
+++ b/loader/loader.c
@@ -2882,7 +2882,7 @@ VkResult loader_create_instance_chain(const VkInstanceCreateInfo *pCreateInfo,
 
             lib_handle = loader_add_layer_lib(inst, "instance", layer_prop);
             if (!lib_handle)
-                continue;   // TODO what should we do in this case
+                continue;
             if ((fpGIPA = layer_prop->functions.get_instance_proc_addr) == NULL) {
                 if (layer_prop->functions.str_gipa == NULL || strlen(layer_prop->functions.str_gipa) == 0) {
                     fpGIPA = (PFN_vkGetInstanceProcAddr) loader_platform_get_proc_address(lib_handle, "vkGetInstanceProcAddr");
@@ -2891,8 +2891,6 @@ VkResult loader_create_instance_chain(const VkInstanceCreateInfo *pCreateInfo,
                     fpGIPA = (PFN_vkGetInstanceProcAddr) loader_platform_get_proc_address(lib_handle, layer_prop->functions.str_gipa);
                 if (!fpGIPA) {
                     loader_log(inst, VK_DEBUG_REPORT_ERROR_BIT_EXT, 0, "Failed to find vkGetInstanceProcAddr in layer %s", layer_prop->lib_name);
-
-                    /* TODO: Should we return nextObj, nextGPA to previous? or decrement layer_list count*/
                     continue;
                 }
             }
@@ -3096,7 +3094,7 @@ VkResult loader_create_device_chain(
 
             lib_handle = loader_add_layer_lib(inst, "device", layer_prop);
             if (!lib_handle)
-                continue;   // TODO what should we do in this case
+                continue;
             if ((fpGIPA = layer_prop->functions.get_instance_proc_addr) == NULL) {
                 if (layer_prop->functions.str_gipa == NULL || strlen(layer_prop->functions.str_gipa) == 0) {
                     fpGIPA = (PFN_vkGetInstanceProcAddr) loader_platform_get_proc_address(lib_handle, "vkGetInstanceProcAddr");
@@ -3105,8 +3103,6 @@ VkResult loader_create_device_chain(
                     fpGIPA = (PFN_vkGetInstanceProcAddr) loader_platform_get_proc_address(lib_handle, layer_prop->functions.str_gipa);
                 if (!fpGIPA) {
                     loader_log(inst, VK_DEBUG_REPORT_ERROR_BIT_EXT, 0, "Failed to find vkGetInstanceProcAddr in layer %s", layer_prop->lib_name);
-
-                    /* TODO: Should we return nextObj, nextGPA to previous? or decrement layer_list count*/
                     continue;
                 }
             }
@@ -3118,8 +3114,6 @@ VkResult loader_create_device_chain(
                     fpGDPA = (PFN_vkGetDeviceProcAddr) loader_platform_get_proc_address(lib_handle, layer_prop->functions.str_gdpa);
                 if (!fpGDPA) {
                     loader_log(inst, VK_DEBUG_REPORT_ERROR_BIT_EXT, 0, "Failed to find vkGetDeviceProcAddr in layer %s", layer_prop->lib_name);
-
-                    /* TODO: Should we return nextObj, nextGPA to previous? or decrement layer_list count*/
                     continue;
                 }
             }
diff --git a/loader/trampoline.c b/loader/trampoline.c
index d525158..35f0853 100644
--- a/loader/trampoline.c
+++ b/loader/trampoline.c
@@ -187,7 +187,6 @@ LOADER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateInstance(
         *pInstance = created_instance;
 
         /*
-         * TODO: This can go away now?
          * Finally have the layers in place and everyone has seen
          * the CreateInstance command go by. This allows the layer's
          * GetInstanceProcAddr functions to return valid extension functions