From: Ming Qian Date: Mon, 9 May 2022 07:52:25 +0000 (+0200) Subject: media: amphion: G/S_PARM only for encoder's output queue X-Git-Tag: v6.6.17~7479^2~105 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=d67005b7dc8235870fca149e1fb149340eeaa698;p=platform%2Fkernel%2Flinux-rpi.git media: amphion: G/S_PARM only for encoder's output queue G/S_PARM doesn't make sense for the capture queue of a stateful encoder, unless V4L2_FMT_FLAG_ENC_CAP_FRAME_INTERVAL is set to reserve hardware resources. Otherwise it will fail the v4l2-compliance Signed-off-by: Ming Qian Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab --- diff --git a/drivers/media/platform/amphion/venc.c b/drivers/media/platform/amphion/venc.c index ba9f49c..43d61d8 100644 --- a/drivers/media/platform/amphion/venc.c +++ b/drivers/media/platform/amphion/venc.c @@ -283,6 +283,9 @@ static int venc_g_parm(struct file *file, void *fh, struct v4l2_streamparm *parm if (!parm) return -EINVAL; + if (!V4L2_TYPE_IS_OUTPUT(parm->type)) + return -EINVAL; + if (!vpu_helper_check_type(inst, parm->type)) return -EINVAL; @@ -304,6 +307,9 @@ static int venc_s_parm(struct file *file, void *fh, struct v4l2_streamparm *parm if (!parm) return -EINVAL; + if (!V4L2_TYPE_IS_OUTPUT(parm->type)) + return -EINVAL; + if (!vpu_helper_check_type(inst, parm->type)) return -EINVAL;