From: Guenter Roeck Date: Wed, 8 Feb 2017 22:05:56 +0000 (-0800) Subject: hwmon: (it87) Fix pwm4 detection for IT8620 and IT8628 X-Git-Tag: v4.11-rc1~180^2~4 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=d66777caa57ffade6061782f3a4d4056f0b0c1ac;p=platform%2Fkernel%2Flinux-exynos.git hwmon: (it87) Fix pwm4 detection for IT8620 and IT8628 pwm4 is enabled if bit 2 of GPIO control register 4 is disabled, not when it is enabled. Since the check is for the skip condition, it is reversed. This applies to both IT8620 and IT8628. Fixes: 36c4d98a7883d ("hwmon: (it87) Add support for all pwm channels ...") Signed-off-by: Guenter Roeck --- diff --git a/drivers/hwmon/it87.c b/drivers/hwmon/it87.c index 85918d8..4f3fabc 100644 --- a/drivers/hwmon/it87.c +++ b/drivers/hwmon/it87.c @@ -2614,7 +2614,7 @@ static int __init it87_find(int sioaddr, unsigned short *address, /* Check for pwm4 */ reg = superio_inb(sioaddr, IT87_SIO_GPIO4_REG); - if (!(reg & BIT(2))) + if (reg & BIT(2)) sio_data->skip_pwm |= BIT(3); /* Check for pwm2, fan2 */