From: Thomas Gleixner Date: Wed, 16 Jul 2014 21:04:47 +0000 (+0000) Subject: hwmon: ibmaem: Use ktime_get_ns() X-Git-Tag: v3.17-rc1~109^2~29 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=d659f9b135fe26b966a6a4ad7281d35d7dbb1366;p=platform%2Fkernel%2Flinux-exynos.git hwmon: ibmaem: Use ktime_get_ns() Using the wall clock time for delta time calculations is wrong to begin with because wall clock time can be set from userspace and NTP. Such data wants to be based on clock monotonic. The calculations also are done on a nanosecond basis. Use the nanoseconds based interface right away. Signed-off-by: Thomas Gleixner Cc: Jean Delvare Acked-by: Jean Delvare Signed-off-by: John Stultz --- diff --git a/drivers/hwmon/ibmaem.c b/drivers/hwmon/ibmaem.c index 632f1dc..7a8a6fb 100644 --- a/drivers/hwmon/ibmaem.c +++ b/drivers/hwmon/ibmaem.c @@ -842,11 +842,10 @@ static ssize_t aem_show_power(struct device *dev, struct aem_data *data = dev_get_drvdata(dev); u64 before, after, delta, time; signed long leftover; - struct timespec b, a; mutex_lock(&data->lock); update_aem_energy_one(data, attr->index); - getnstimeofday(&b); + time = ktime_get_ns(); before = data->energy[attr->index]; leftover = schedule_timeout_interruptible( @@ -858,11 +857,10 @@ static ssize_t aem_show_power(struct device *dev, } update_aem_energy_one(data, attr->index); - getnstimeofday(&a); + time = ktime_get_ns() - time; after = data->energy[attr->index]; mutex_unlock(&data->lock); - time = timespec_to_ns(&a) - timespec_to_ns(&b); delta = (after - before) * UJ_PER_MJ; return sprintf(buf, "%llu\n",