From: discomfitor <discomfitor@7cbeb6ba-43b4-40fd-8cce-4c39aea84d33>
Date: Fri, 21 Oct 2011 04:38:21 +0000 (+0000)
Subject: calling memcpy on an uninitialized pointer??? who would do such a thing!
X-Git-Tag: REL_F_I9500_20120323_1~17^2~1553
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=d5c71ce9432ca3c60faced9b9273a11e81a261ea;p=framework%2Fuifw%2Felementary.git

calling memcpy on an uninitialized pointer??? who would do such a thing!


git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/elementary@64232 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33
---

diff --git a/src/lib/elm_cnp_helper.c b/src/lib/elm_cnp_helper.c
index 5e9b10b..c0b5d01 100644
--- a/src/lib/elm_cnp_helper.c
+++ b/src/lib/elm_cnp_helper.c
@@ -600,6 +600,7 @@ targets_converter(char *target __UNUSED__, void *data, int size, void **data_ret
      {
         if (data_ret)
           {
+             *data_ret = malloc(size * sizeof(char) + 1);
              memcpy(*data_ret, data, size);
              ((char**)(data_ret))[0][size] = 0;
           }
@@ -811,9 +812,9 @@ notify_handler_uri(Cnp_Selection *sel, Ecore_X_Event_Selection_Notify *notify)
      }
    else
      {
+        stripstr = p = malloc(data->length * sizeof(char) + 1);
         memcpy(stripstr, data->data, data->length);
         stripstr[data->length] = 0;
-        p = stripstr;
      }
 
    if (!p)
@@ -988,6 +989,7 @@ text_converter(char *target __UNUSED__, void *data, int size, void **data_ret, i
      {
         if (data_ret)
           {
+             *data_ret = malloc(size * sizeof(char) + 1);
              memcpy(*data_ret, data, size);
              ((char**)(data_ret))[0][size] = 0;
           }
@@ -1034,6 +1036,7 @@ general_converter(char *target __UNUSED__, void *data, int size, void **data_ret
      {
         if (data_ret)
           {
+             *data_ret = malloc(size * sizeof(char) + 1);
              memcpy(*data_ret, data, size);
              ((char**)(data_ret))[0][size] = 0;
           }