From: Eric Christopher Date: Sat, 21 Feb 2015 08:32:38 +0000 (+0000) Subject: Turn an if+llvm_unreachable into an assert and reword comment. X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=d5bc07e8662c3896fb7a207fc1f03006c7be4520;p=platform%2Fupstream%2Fllvm.git Turn an if+llvm_unreachable into an assert and reword comment. llvm-svn: 230132 --- diff --git a/llvm/lib/Target/Mips/MipsAsmPrinter.cpp b/llvm/lib/Target/Mips/MipsAsmPrinter.cpp index aeee5e5..d3fd941 100644 --- a/llvm/lib/Target/Mips/MipsAsmPrinter.cpp +++ b/llvm/lib/Target/Mips/MipsAsmPrinter.cpp @@ -976,13 +976,10 @@ void MipsAsmPrinter::EmitFPCallStub( OutContext.GetOrCreateSymbol("__call_stub_fp_" + Twine(Symbol)); OutStreamer.EmitSymbolAttribute(MType, MCSA_ELF_TypeFunction); OutStreamer.EmitLabel(Stub); - // - // we just handle non pic for now. these function will not be - // called otherwise. when the full stub generation is moved here - // we need to deal with pic. - // - if (TM.getRelocationModel() == Reloc::PIC_) - llvm_unreachable("should not be here if we are compiling pic"); + + // Only handle non-pic for now. + assert(TM.getRelocationModel() != Reloc::PIC_ && + "should not be here if we are compiling pic"); TS.emitDirectiveSetReorder(); // // We need to add a MipsMCExpr class to MCTargetDesc to fully implement