From: Márton Németh Date: Sat, 16 Jan 2010 16:21:59 +0000 (-0300) Subject: V4L/DVB: cx231xx: cleanup dvb_attach() return value handling X-Git-Tag: v2.6.34-rc1~280^2~191 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=d5abcc784ff337fbe9c6bc03235baecfd25191e5;p=profile%2Fcommon%2Fkernel-common.git V4L/DVB: cx231xx: cleanup dvb_attach() return value handling Remove the following sparse error (see "make C=1"): * error: incompatible types for operation (<) left side has type struct dvb_frontend * right side has type int Signed-off-by: Márton Németh Signed-off-by: Mauro Carvalho Chehab --- diff --git a/drivers/media/video/cx231xx/cx231xx-dvb.c b/drivers/media/video/cx231xx/cx231xx-dvb.c index c5082a4..64e025e 100644 --- a/drivers/media/video/cx231xx/cx231xx-dvb.c +++ b/drivers/media/video/cx231xx/cx231xx-dvb.c @@ -464,9 +464,9 @@ static int dvb_init(struct cx231xx *dev) /* define general-purpose callback pointer */ dvb->frontend->callback = cx231xx_tuner_callback; - if (dvb_attach(xc5000_attach, dev->dvb->frontend, + if (!dvb_attach(xc5000_attach, dev->dvb->frontend, &dev->i2c_bus[1].i2c_adap, - &cnxt_rde250_tunerconfig) < 0) { + &cnxt_rde250_tunerconfig)) { result = -EINVAL; goto out_free; } @@ -486,9 +486,9 @@ static int dvb_init(struct cx231xx *dev) /* define general-purpose callback pointer */ dvb->frontend->callback = cx231xx_tuner_callback; - if (dvb_attach(xc5000_attach, dev->dvb->frontend, + if (!dvb_attach(xc5000_attach, dev->dvb->frontend, &dev->i2c_bus[1].i2c_adap, - &cnxt_rde250_tunerconfig) < 0) { + &cnxt_rde250_tunerconfig)) { result = -EINVAL; goto out_free; }