From: Jason Ekstrand <jason.ekstrand@intel.com>
Date: Wed, 18 Oct 2017 01:56:29 +0000 (-0700)
Subject: intel/fs: Fix integer multiplication lowering for src/dst hazards
X-Git-Tag: upstream/18.1.0~4415
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=d54f8ec744545673fd78f15ffce3cb4e47d4b5f1;p=platform%2Fupstream%2Fmesa.git

intel/fs: Fix integer multiplication lowering for src/dst hazards

Reviewed-by: Iago Toral Quiroga <itoral@igalia.com>
Cc: mesa-stable@lists.freedesktop.org
---

diff --git a/src/intel/compiler/brw_fs.cpp b/src/intel/compiler/brw_fs.cpp
index 965eb86..fea5a14 100644
--- a/src/intel/compiler/brw_fs.cpp
+++ b/src/intel/compiler/brw_fs.cpp
@@ -3487,8 +3487,14 @@ fs_visitor::lower_integer_multiplication()
              * schedule multi-component multiplications much better.
              */
 
+            bool needs_mov = false;
             fs_reg orig_dst = inst->dst;
-            if (orig_dst.is_null() || orig_dst.file == MRF) {
+            if (orig_dst.is_null() || orig_dst.file == MRF ||
+                regions_overlap(inst->dst, inst->size_written,
+                                inst->src[0], inst->size_read(0)) ||
+                regions_overlap(inst->dst, inst->size_written,
+                                inst->src[1], inst->size_read(1))) {
+               needs_mov = true;
                inst->dst = fs_reg(VGRF, alloc.allocate(dispatch_width / 8),
                                   inst->dst.type);
             }
@@ -3519,7 +3525,7 @@ fs_visitor::lower_integer_multiplication()
                      subscript(low, BRW_REGISTER_TYPE_UW, 1),
                      subscript(high, BRW_REGISTER_TYPE_UW, 0));
 
-            if (inst->conditional_mod || orig_dst.file == MRF) {
+            if (needs_mov || inst->conditional_mod) {
                set_condmod(inst->conditional_mod,
                            ibld.MOV(orig_dst, inst->dst));
             }