From: Mehdi Amini <aminim@google.com>
Date: Wed, 22 May 2019 19:22:51 +0000 (-0700)
Subject:     Return nullptr on Region::getContainingOperation()/getContainingFunction() instea... 
X-Git-Tag: llvmorg-11-init~1466^2~1634
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=d5397f4efe126c5fa1cebf9634d8c1e12d21ec56;p=platform%2Fupstream%2Fllvm.git

Return nullptr on Region::getContainingOperation()/getContainingFunction() instead of asserting

    This avoids crashing when trying to dump an operation nested in a region that isn't yet attached to an operation, which is quite useful when debugging.

    This alone won't be enough to print an unlink Operation, it'll display `<<UNLINKED INSTRUCTION>>`.

--

PiperOrigin-RevId: 249496388
---

diff --git a/mlir/lib/IR/Block.cpp b/mlir/lib/IR/Block.cpp
index a440ca9..2ed8fd0 100644
--- a/mlir/lib/IR/Block.cpp
+++ b/mlir/lib/IR/Block.cpp
@@ -289,12 +289,10 @@ Region *Region::getContainingRegion() {
 }
 
 Operation *Region::getContainingOp() {
-  assert(!container.isNull() && "no container");
   return container.dyn_cast<Operation *>();
 }
 
 Function *Region::getContainingFunction() {
-  assert(!container.isNull() && "no container");
   return container.dyn_cast<Function *>();
 }