From: Guennadi Liakhovetski Date: Tue, 14 Feb 2012 10:37:17 +0000 (+0100) Subject: usb: renesas_usbhs: (cosmetic) simplify list operations X-Git-Tag: v3.4-rc1~184^2~22^2~39^2~24 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=d5261286949fc9ada701c7e30bf89e08a6dbf4de;p=profile%2Fivi%2Fkernel-x86-ivi.git usb: renesas_usbhs: (cosmetic) simplify list operations list.h already provide helpers to find the first entry and to move list nodes to the tail of another list. This patch simply uses those helpers, no functional changes. Signed-off-by: Guennadi Liakhovetski Signed-off-by: Felipe Balbi --- diff --git a/drivers/usb/renesas_usbhs/fifo.c b/drivers/usb/renesas_usbhs/fifo.c index 03a9cc5..fb2a88c 100644 --- a/drivers/usb/renesas_usbhs/fifo.c +++ b/drivers/usb/renesas_usbhs/fifo.c @@ -76,8 +76,7 @@ void usbhs_pkt_push(struct usbhs_pipe *pipe, struct usbhs_pkt *pkt, pipe->handler = &usbhsf_null_handler; } - list_del_init(&pkt->node); - list_add_tail(&pkt->node, &pipe->list); + list_move_tail(&pkt->node, &pipe->list); /* * each pkt must hold own handler. @@ -107,7 +106,7 @@ static struct usbhs_pkt *__usbhsf_pkt_get(struct usbhs_pipe *pipe) if (list_empty(&pipe->list)) return NULL; - return list_entry(pipe->list.next, struct usbhs_pkt, node); + return list_first_entry(&pipe->list, struct usbhs_pkt, node); } struct usbhs_pkt *usbhs_pkt_pop(struct usbhs_pipe *pipe, struct usbhs_pkt *pkt)