From: Sangchul Lee Date: Fri, 27 May 2022 01:32:03 +0000 (+0900) Subject: webrtc_private: Use PA_PROP_XXX defines instead of hard-coded string X-Git-Tag: submit/tizen/20220602.125915~4 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=d5194845e417865734bf9bbc05cc58052b16f3a4;p=platform%2Fcore%2Fapi%2Fwebrtc.git webrtc_private: Use PA_PROP_XXX defines instead of hard-coded string [Version] 0.3.110 [Issue Type] Improvement Change-Id: I76d4f7e1af27e01bd8beb2fd2a1e228a77ddbc58 Signed-off-by: Sangchul Lee --- diff --git a/CMakeLists.txt b/CMakeLists.txt index ec585c10..569d11bd 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -11,7 +11,7 @@ SET(INC_DIR include) INCLUDE_DIRECTORIES(${INC_DIR}) SET(dependents "dlog glib-2.0 gstreamer-1.0 gstreamer-webrtc-1.0 gstreamer-video-1.0 gstreamer-audio-1.0 \ - gstreamer-allocators-1.0 json-glib-1.0 iniparser mm-common mm-display-interface capi-media-tool \ + gstreamer-allocators-1.0 libpulse json-glib-1.0 iniparser mm-common mm-display-interface capi-media-tool \ libtbm libwebsockets cynara-client libsmack capi-system-info libsoup-2.4 bundle capi-media-sound-manager") IF(NOT TIZEN_PROFILE_TV) SET(dependents "${dependents} mm-resource-manager") diff --git a/packaging/capi-media-webrtc.spec b/packaging/capi-media-webrtc.spec index 49cdc0c0..e5590360 100644 --- a/packaging/capi-media-webrtc.spec +++ b/packaging/capi-media-webrtc.spec @@ -1,6 +1,6 @@ Name: capi-media-webrtc Summary: A WebRTC library in Tizen Native API -Version: 0.3.109 +Version: 0.3.110 Release: 0 Group: Multimedia/API License: Apache-2.0 @@ -17,6 +17,7 @@ BuildRequires: pkgconfig(gstreamer-webrtc-1.0) BuildRequires: pkgconfig(gstreamer-video-1.0) BuildRequires: pkgconfig(gstreamer-audio-1.0) BuildRequires: pkgconfig(gstreamer-allocators-1.0) +BuildRequires: pkgconfig(libpulse) BuildRequires: pkgconfig(appcore-efl) BuildRequires: pkgconfig(elementary) BuildRequires: pkgconfig(json-glib-1.0) diff --git a/src/webrtc_private.c b/src/webrtc_private.c index 7081997e..85276d8c 100644 --- a/src/webrtc_private.c +++ b/src/webrtc_private.c @@ -14,9 +14,10 @@ * limitations under the License. */ -#include #include "webrtc.h" #include "webrtc_private.h" +#include +#include #define DEFAULT_DOT_FILE_NAME_PREFIX "webrtc" @@ -2208,7 +2209,7 @@ int _apply_stream_info(GstElement *element, const char *stream_type, int stream_ RET_VAL_IF(!g_object_class_find_property(G_OBJECT_GET_CLASS(G_OBJECT(element)), "stream-properties"), WEBRTC_ERROR_INVALID_OPERATION, "could not find 'stream-properties'"); - snprintf(values, sizeof(values) - 1, "props,media.role=%s, media.parent_id=%d", stream_type, stream_index); + snprintf(values, sizeof(values) - 1, "props,%s=%s, %s=%d", PA_PROP_MEDIA_ROLE, stream_type, PA_PROP_MEDIA_PARENT_ID, stream_index); RET_VAL_IF(!(structure = gst_structure_from_string(values, NULL)), WEBRTC_ERROR_INVALID_OPERATION, "failed to gst_structure_from_string(), [%s]", values);