From: Yunjin Lee <yunjin-.lee@samsung.com>
Date: Thu, 9 Jul 2020 02:24:07 +0000 (+0900)
Subject: Fix asan build fail
X-Git-Tag: submit/tizen/20200720.104233~6^2
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=d511f071efd73306cc641a3bef59f518f81ba99e;p=platform%2Fcore%2Fsecurity%2Fprivilege-checker.git

Fix asan build fail

- How to build with asan:
    $ gbs build -A {architecture} --include-all --extra-packs asan-force-options,asan-build-env --define 'asan 1'

Change-Id: I4c655ac01d9061362a1cf1cc53bc6defe14bc55d
Signed-off-by: Yunjin Lee <yunjin-.lee@samsung.com>
---

diff --git a/test/tc-common.c b/test/tc-common.c
index 8fe6ec5..a7dfbe2 100755
--- a/test/tc-common.c
+++ b/test/tc-common.c
@@ -4,6 +4,7 @@
 #include <stdarg.h>
 #include <stdbool.h>
 #include <glib.h>
+#include <glib/gprintf.h>
 #include <tc-common.h>
 #include <iniparser.h>
 
@@ -127,26 +128,28 @@ void __print_error_message(char *error_message)
 	char *temp = strdup(error_message);
 	char *save = NULL;
 
-	char err_type[256] = { 0, };
+	const int err_type_size = 256;
+	char err_type[err_type_size];
+	memset(err_type, 0, err_type_size*sizeof(char));
 
 	if (strstr(error_message, "DEPRECATED") != NULL)
-		strncat(err_type, "PRVMGR_ERR_DEPRECATED_PRIVILEGE ", strlen("PRVMGR_ERR_DEPRECATED_PRIVILEGE "));
+		g_strlcat(err_type, "PRVMGR_ERR_DEPRECATED_PRIVILEGE ", err_type_size);
 
 	if (strstr(error_message, "NO_EXIST") != NULL)
-		strncat(err_type, "PRVMGR_ERR_NO_EXIST_PRIVILEGE ", strlen("PRVMGR_ERR_NO_EXIST_PRIVILEGE "));
+		g_strlcat(err_type, "PRVMGR_ERR_NO_EXIST_PRIVILEGE ", err_type_size);
 
 	if (strstr(error_message, "MISMATCHED") != NULL)
-		strncat(err_type, "PRVMGR_ERR_MISMACHED_PRIVILEGE_LEVEL ", strlen("PRVMGR_ERR_MISMACHED_PRIVILEGE_LEVEL "));
+		g_strlcat(err_type, "PRVMGR_ERR_MISMACHED_PRIVILEGE_LEVEL ", err_type_size);
 
 	if (strstr(error_message, "INVALID_PARAMETER") != NULL)
-		strncat(err_type, "PRVMGR_ERR_INVALID_PARAMETER ", strlen("PRVMGR_ERR_INVALID_PARAMETER "));
+		g_strlcat(err_type, "PRVMGR_ERR_INVALID_PARAMETER ", err_type_size);
 
 	if (strstr(error_message, "banned") != NULL)
-		strncat(err_type, "PRVMGR_ERR_USING_BANNED_PRIVILEGE ", strlen("PRVMGR_ERR_USING_BANNED_PRIVILEGE "));
+		g_strlcat(err_type, "PRVMGR_ERR_USING_BANNED_PRIVILEGE ", err_type_size);
 
 	if (strlen(err_type) == 0) {
 		fail_cnt++;
-		strncat(err_type, "test failed - unknown error type", strlen("test failed - unknown error type "));
+		g_strlcat(err_type, "test failed - unknown error type", err_type_size);
 		__color_to_red();
 	} else {
 		__color_to_blue();