From: Charles Giessen Date: Mon, 31 Oct 2022 22:37:14 +0000 (-0600) Subject: Null check vk_icdGetPhysicalDeviceProcAddr X-Git-Tag: upstream/1.3.240~69 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=d4fd5773d5a004a841e2e976ef1a23aed53e8330;p=platform%2Fupstream%2FVulkan-Loader.git Null check vk_icdGetPhysicalDeviceProcAddr Forgotten NULL check causes crashes if a driver forgets to export vk_icdGetPhysicalDeviceProcAddr but does report a 4 or higher ICD Interface Version. --- diff --git a/loader/unknown_function_handling.c b/loader/unknown_function_handling.c index 6eb6918b..2fbb2e79 100644 --- a/loader/unknown_function_handling.c +++ b/loader/unknown_function_handling.c @@ -188,6 +188,7 @@ bool loader_check_icds_for_phys_dev_ext_address(struct loader_instance *inst, co icd_term = inst->icd_terms; while (NULL != icd_term) { if (icd_term->scanned_icd->interface_version >= MIN_PHYS_DEV_EXTENSION_ICD_INTERFACE_VERSION && + icd_term->scanned_icd->GetPhysicalDeviceProcAddr && icd_term->scanned_icd->GetPhysicalDeviceProcAddr(icd_term->instance, funcName)) // this icd supports funcName return true;