From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Date: Wed, 24 Mar 2021 20:01:34 +0000 (+0100)
Subject: pwm: bcm-iproc: Free resources only after pwmchip_remove()
X-Git-Tag: accepted/tizen/unified/20230118.172025~7285^2~20
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=d4ac3917bca64a4f630dc6f7ba47fe71dbf0273e;p=platform%2Fkernel%2Flinux-rpi.git

pwm: bcm-iproc: Free resources only after pwmchip_remove()

Before pwmchip_remove() returns the PWM is expected to be functional. So
remove the pwmchip before disabling the clock.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
---

diff --git a/drivers/pwm/pwm-bcm-iproc.c b/drivers/pwm/pwm-bcm-iproc.c
index 529a66a..edd2ce1 100644
--- a/drivers/pwm/pwm-bcm-iproc.c
+++ b/drivers/pwm/pwm-bcm-iproc.c
@@ -253,9 +253,11 @@ static int iproc_pwmc_remove(struct platform_device *pdev)
 {
 	struct iproc_pwmc *ip = platform_get_drvdata(pdev);
 
+	pwmchip_remove(&ip->chip);
+
 	clk_disable_unprepare(ip->clk);
 
-	return pwmchip_remove(&ip->chip);
+	return 0;
 }
 
 static const struct of_device_id bcm_iproc_pwmc_dt[] = {