From: Edward Hervey <edward.hervey@collabora.co.uk>
Date: Thu, 13 Oct 2011 07:34:04 +0000 (+0200)
Subject: rtpssrcdemux: Fix wrong usage of gst_iterator_filter
X-Git-Tag: RELEASE-0.11.1~336
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=d4a2a466062bb3a1f07c68c076c6661878b633b3;p=platform%2Fupstream%2Fgst-plugins-good.git

rtpssrcdemux: Fix wrong usage of gst_iterator_filter

It takes a GValue* as the user_data.

And don't forget to unref the demuxer before returning.
---

diff --git a/gst/rtpmanager/gstrtpssrcdemux.c b/gst/rtpmanager/gstrtpssrcdemux.c
index 13573c8..e298299 100644
--- a/gst/rtpmanager/gstrtpssrcdemux.c
+++ b/gst/rtpmanager/gstrtpssrcdemux.c
@@ -734,23 +734,28 @@ gst_rtp_ssrc_demux_iterate_internal_links_sink (GstPad * pad)
 {
   GstRtpSsrcDemux *demux;
   GstIterator *it = NULL;
-  const gchar *prefix = NULL;
+  GValue gval = { 0, };
 
   demux = GST_RTP_SSRC_DEMUX (gst_pad_get_parent (pad));
 
   if (!demux)
     return NULL;
 
+  g_value_init (&gval, G_TYPE_STRING);
   if (pad == demux->rtp_sink)
-    prefix = "src_";
+    g_value_set_static_string (&gval, "src_");
   else if (pad == demux->rtcp_sink)
-    prefix = "rtcp_src_";
+    g_value_set_static_string (&gval, "rtcp_src_");
   else
     g_assert_not_reached ();
 
   it = gst_element_iterate_src_pads (GST_ELEMENT (demux));
 
-  return gst_iterator_filter (it, src_pad_compare_func, (gpointer) prefix);
+  it = gst_iterator_filter (it, src_pad_compare_func, &gval);
+
+  gst_object_unref (demux);
+
+  return it;
 }