From: Nishka Dasgupta Date: Sun, 4 Aug 2019 16:31:51 +0000 (+0530) Subject: clk: st: clk-flexgen: Add of_node_put() in st_of_flexgen_setup() X-Git-Tag: v5.4-rc1~97^2~5^3~1 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=d432d04560301c6350158dc4a7e8275b331fd480;p=platform%2Fkernel%2Flinux-rpi.git clk: st: clk-flexgen: Add of_node_put() in st_of_flexgen_setup() In function st_of_flexgen_setup, variable pnode takes the return value of of_get_parent, which gets a node but does not put it. If pnode is not put before the function returns, it may cause a memory leak. Hence put pnode after its last occurrence. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta Link: https://lkml.kernel.org/r/20190804163151.6511-1-nishkadg.linux@gmail.com Signed-off-by: Stephen Boyd --- diff --git a/drivers/clk/st/clk-flexgen.c b/drivers/clk/st/clk-flexgen.c index d18e49b..4413b6e04 100644 --- a/drivers/clk/st/clk-flexgen.c +++ b/drivers/clk/st/clk-flexgen.c @@ -326,6 +326,7 @@ static void __init st_of_flexgen_setup(struct device_node *np) return; reg = of_iomap(pnode, 0); + of_node_put(pnode); if (!reg) return;