From: Daniel Wagner <wagi@monom.org>
Date: Mon, 5 Apr 2021 15:25:27 +0000 (+0200)
Subject: wireguard: Copy interfance names obeying lengths rules
X-Git-Tag: accepted/tizen/unified/20210915.025055~7^2
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=d4281c2cb7c8b1ad02669a03369872230394b509;p=platform%2Fupstream%2Fconnman.git

wireguard: Copy interfance names obeying lengths rules

gcc points out the destination buffer has the same size the specified
bound for the string.

  warning: ‘__builtin_strncpy’ specified bound 16 equals destination size [-Wstringop-truncation]

Let's make sure we do not overflow the buffer (should not happen as
the names are provide by the kernel and hence should fit).

Change-Id: I1e8818f0820ffb32083e14cb88e4919fd8b12798
Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
---

diff --git a/vpn/plugins/wireguard.c b/vpn/plugins/wireguard.c
index ec57c93..1da0ffb 100644
--- a/vpn/plugins/wireguard.c
+++ b/vpn/plugins/wireguard.c
@@ -407,7 +407,7 @@ static int wg_connect(struct vpn_provider *provider,
 		err = -ENOENT;
 		goto done;
 	}
-	stpncpy(info->device.name, ifname, sizeof(info->device.name));
+	stpncpy(info->device.name, ifname, sizeof(info->device.name) - 1);
 	g_free(ifname);
 
 	err = wg_add_device(info->device.name);