From: Lachlan McIlroy Date: Mon, 22 Dec 2008 06:50:56 +0000 (+1100) Subject: [XFS] Use the incore inode size in xfs_file_readdir() X-Git-Tag: v2.6.30-rc8~5^2~58 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=d415867e0abc35e3b2f0d4196e98c339d6fe29a2;p=profile%2Fivi%2Fkernel-x86-ivi.git [XFS] Use the incore inode size in xfs_file_readdir() We should be using the incore inode size here not the linux inode size. The incore inode size is always up to date for directories whereas the linux inode size is not updated for directories. We've hit assertions in xfs_bmap() and traced it back to the linux inode size being zero but the incore size being correct. Reviewed-by: Christoph Hellwig Signed-off-by: Lachlan McIlroy --- diff --git a/fs/xfs/linux-2.6/xfs_file.c b/fs/xfs/linux-2.6/xfs_file.c index a0c45cc..e14c4e3 100644 --- a/fs/xfs/linux-2.6/xfs_file.c +++ b/fs/xfs/linux-2.6/xfs_file.c @@ -204,7 +204,7 @@ xfs_file_readdir( * point we can change the ->readdir prototype to include the * buffer size. */ - bufsize = (size_t)min_t(loff_t, PAGE_SIZE, inode->i_size); + bufsize = (size_t)min_t(loff_t, PAGE_SIZE, ip->i_d.di_size); error = xfs_readdir(ip, dirent, bufsize, (xfs_off_t *)&filp->f_pos, filldir);