From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Date: Sun, 19 Feb 2017 12:07:59 +0000 (+0100)
Subject: HID: i2c-hid: Fix error handling
X-Git-Tag: v4.14-rc1~1022^2~2^6
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=d3d9adfe3059cb5cb330a2da74ea0bad49b482c0;p=platform%2Fkernel%2Flinux-rpi.git

HID: i2c-hid: Fix error handling

According to error handling in this function, it is likely that some
resources should be freed before returning.
Replace 'return ret', with 'goto err'.

While at it, remove some spaces at the beginning of the lines to be more
consistent.

Fixes: ead0687fe304a ("HID: i2c-hid: support regulator power on/off")

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
---

diff --git a/drivers/hid/i2c-hid/i2c-hid.c b/drivers/hid/i2c-hid/i2c-hid.c
index a3f6daf..a838149 100644
--- a/drivers/hid/i2c-hid/i2c-hid.c
+++ b/drivers/hid/i2c-hid/i2c-hid.c
@@ -1064,7 +1064,7 @@ static int i2c_hid_probe(struct i2c_client *client,
 		if (ret != -EPROBE_DEFER)
 			dev_err(&client->dev, "Failed to get regulator: %d\n",
 				ret);
-		return ret;
+		goto err;
 	}
 
 	ret = regulator_enable(ihid->pdata.supply);