From: Jan Vorlicek <janvorli@microsoft.com>
Date: Mon, 1 Apr 2019 10:07:35 +0000 (+0200)
Subject: Deliver Unload event at exit for all ALCs
X-Git-Tag: accepted/tizen/unified/20190813.215958~53^2~31^2~1
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=d3ce81006b227b4502a9690d14f8b8e9cfa9b2e0;p=platform%2Fupstream%2Fcoreclr.git

Deliver Unload event at exit for all ALCs

Sending it just for collectible ALCs is not correct at process exit.
---

diff --git a/src/System.Private.CoreLib/shared/System/Runtime/Loader/AssemblyLoadContext.cs b/src/System.Private.CoreLib/shared/System/Runtime/Loader/AssemblyLoadContext.cs
index d5d9b03..2c68a27 100644
--- a/src/System.Private.CoreLib/shared/System/Runtime/Loader/AssemblyLoadContext.cs
+++ b/src/System.Private.CoreLib/shared/System/Runtime/Loader/AssemblyLoadContext.cs
@@ -106,36 +106,34 @@ namespace System.Runtime.Loader
             }
         }
 
+        private void RaiseUnloadEvent()
+        {
+            // Ensure that we raise the Unload event only once
+            Interlocked.Exchange(ref Unloading, null)?.Invoke(this);
+        }
+
         private void InitiateUnload()
         {
-            var unloading = Unloading;
-            Unloading = null;
-            unloading?.Invoke(this);
+            RaiseUnloadEvent();
 
             // When in Unloading state, we are not supposed to be called on the finalizer
             // as the native side is holding a strong reference after calling Unload
             lock (_unloadLock)
             {
-                if (!s_isProcessExiting)
-                {
-                    Debug.Assert(_state == InternalState.Alive);
+                Debug.Assert(_state == InternalState.Alive);
 
-                    var thisStrongHandle = GCHandle.Alloc(this, GCHandleType.Normal);
-                    var thisStrongHandlePtr = GCHandle.ToIntPtr(thisStrongHandle);
-                    // The underlying code will transform the original weak handle
-                    // created by InitializeLoadContext to a strong handle
-                    PrepareForAssemblyLoadContextRelease(_nativeAssemblyLoadContext, thisStrongHandlePtr);
-                }
+                var thisStrongHandle = GCHandle.Alloc(this, GCHandleType.Normal);
+                var thisStrongHandlePtr = GCHandle.ToIntPtr(thisStrongHandle);
+                // The underlying code will transform the original weak handle
+                // created by InitializeLoadContext to a strong handle
+                PrepareForAssemblyLoadContextRelease(_nativeAssemblyLoadContext, thisStrongHandlePtr);
 
                 _state = InternalState.Unloading;
             }
 
-            if (!s_isProcessExiting)
+            lock (s_allContexts)
             {
-                lock (s_allContexts)
-                {
-                    s_allContexts.Remove(_id);
-                }
+                s_allContexts.Remove(_id);
             }
         }
 
@@ -390,10 +388,9 @@ namespace System.Runtime.Loader
                 s_isProcessExiting = true;
                 foreach (var alcAlive in s_allContexts)
                 {
-                    if (alcAlive.Value.TryGetTarget(out AssemblyLoadContext alc) && alc.IsCollectible)
+                    if (alcAlive.Value.TryGetTarget(out AssemblyLoadContext alc))
                     {
-                        // Should we use a try/catch?
-                        alc.InitiateUnload();
+                        alc.RaiseUnloadEvent();
                     }
                 }
                 s_allContexts.Clear();