From: Eric Lapuyade Date: Thu, 3 May 2012 12:53:20 +0000 (+0200) Subject: NFC: Removed addressed shdlc TODOs X-Git-Tag: upstream/snapshot3+hdmi~6997^2~57^2~156 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=d3b404453192aa195ccfb2f0d946f880b16f8b1f;p=platform%2Fadaptation%2Frenesas_rcar%2Frenesas_kernel.git NFC: Removed addressed shdlc TODOs The questions asked in the comments have been answered and addressed. Signed-off-by: Eric Lapuyade Signed-off-by: Samuel Ortiz --- diff --git a/net/nfc/hci/shdlc.c b/net/nfc/hci/shdlc.c index d7c74d1..18d1536 100644 --- a/net/nfc/hci/shdlc.c +++ b/net/nfc/hci/shdlc.c @@ -340,15 +340,6 @@ static void nfc_shdlc_connect_complete(struct nfc_shdlc *shdlc, int r) shdlc->state = SHDLC_CONNECTED; } else { shdlc->state = SHDLC_DISCONNECTED; - - /* - * TODO: Could it be possible that there are pending - * executing commands that are waiting for connect to complete - * before they can be carried? As connect is a blocking - * operation, it would require that the userspace process can - * send commands on the same device from a second thread before - * the device is up. I don't think that is possible, is it? - */ } shdlc->connect_result = r; @@ -926,8 +917,6 @@ void nfc_shdlc_free(struct nfc_shdlc *shdlc) { pr_debug("\n"); - /* TODO: Check that this cannot be called while still in use */ - nfc_hci_unregister_device(shdlc->hdev); nfc_hci_free_device(shdlc->hdev);