From: Lang Cheng Date: Fri, 20 Mar 2020 03:23:35 +0000 (+0800) Subject: RDMA/hns: Simplify attribute judgment code X-Git-Tag: v5.15~4184^2~22 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=d398d4ca5f17e7ba762bc897c82afca868e47a7c;p=platform%2Fkernel%2Flinux-starfive.git RDMA/hns: Simplify attribute judgment code Combine attribute flags before masking them. Link: https://lore.kernel.org/r/1584674622-52773-4-git-send-email-liweihang@huawei.com Signed-off-by: Lang Cheng Signed-off-by: Weihang Li Signed-off-by: Jason Gunthorpe --- diff --git a/drivers/infiniband/hw/hns/hns_roce_hw_v2.c b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c index 94cb2984..518a649 100644 --- a/drivers/infiniband/hw/hns/hns_roce_hw_v2.c +++ b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c @@ -4281,8 +4281,7 @@ static int modify_qp_rtr_to_rts(struct ib_qp *ibqp, } /* Not support alternate path and path migration */ - if ((attr_mask & IB_QP_ALT_PATH) || - (attr_mask & IB_QP_PATH_MIG_STATE)) { + if (attr_mask & (IB_QP_ALT_PATH | IB_QP_PATH_MIG_STATE)) { ibdev_err(ibdev, "RTR2RTS attr_mask (0x%x)error\n", attr_mask); return -EINVAL; }