From: seoz Date: Wed, 7 Sep 2011 15:02:27 +0000 (+0000) Subject: elm diskselector: Fixed elm_diskselector_item_selected_set() hanging bug. Patch by... X-Git-Tag: REL_F_I9500_20120323_1~17^2~1832 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=d39098eef4616314eab5d6a4284c1536297b381a;p=framework%2Fuifw%2Felementary.git elm diskselector: Fixed elm_diskselector_item_selected_set() hanging bug. Patch by Hyoyoung Chang On Wed, Sep 7, 2011 at 6:51 PM, Hyoyoung Chang wrote: > Dear developers. > > This patch is fixing - hangs after using elm_diskselector_item_selected_set. > Elm_diskselector add a idler and remove in _move_scroller with checking > wd->idler > But in elm_diskselector_item_selected_set, it's not use wd->idler. > So idler is called infinite. > > It also registered in ticket ( http://trac.enlightenment.org/e/ticket/854 ) > > Thank you On Wed, Sep 7, 2011 at 7:00 PM, Hyoyoung Chang wrote: > I omitted about credit. > With cnook, I can easily find this bug. > Thanks to cnook git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/elementary@63269 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33 --- diff --git a/src/lib/elm_diskselector.c b/src/lib/elm_diskselector.c index e467aeb..66625f6 100644 --- a/src/lib/elm_diskselector.c +++ b/src/lib/elm_diskselector.c @@ -1181,7 +1181,7 @@ elm_diskselector_item_selected_set(Elm_Diskselector_Item *it, Eina_Bool selected } if (!wd->idler) - ecore_idler_add(_move_scroller, it->base.widget); + wd->idler = ecore_idler_add(_move_scroller, it->base.widget); } EAPI Eina_Bool