From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Tue, 10 Jul 2012 20:32:51 +0000 (+0000)
Subject: smsc95xx: signedness bug in get_regs()
X-Git-Tag: v3.6-rc1~125^2~207
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=d348446b8840602091872b8272855dee196f6dd5;p=platform%2Fkernel%2Flinux-stable.git

smsc95xx: signedness bug in get_regs()

"retval" has to be a signed integer for the error handling to work.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/drivers/net/usb/smsc95xx.c b/drivers/net/usb/smsc95xx.c
index 05ecf14..bd7cbaa 100644
--- a/drivers/net/usb/smsc95xx.c
+++ b/drivers/net/usb/smsc95xx.c
@@ -589,7 +589,8 @@ smsc95xx_ethtool_getregs(struct net_device *netdev, struct ethtool_regs *regs,
 			 void *buf)
 {
 	struct usbnet *dev = netdev_priv(netdev);
-	unsigned int i, j, retval;
+	unsigned int i, j;
+	int retval;
 	u32 *data = buf;
 
 	retval = smsc95xx_read_reg(dev, ID_REV, &regs->version);