From: Vincent Whitchurch Date: Tue, 1 Mar 2022 11:18:30 +0000 (+0100) Subject: regulator: virtual: warn against production use X-Git-Tag: v6.6.17~7850^2~10 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=d2fb5487ecb2a28b61ff261ae18488afc98d24a6;p=platform%2Fkernel%2Flinux-rpi.git regulator: virtual: warn against production use This driver is only meant for debugging and testing. Currently, it's not possible to use it without patching the kernel since it requires platform data, but we'll be adding devicetree support, so add a loud warning to make it clear that it's still only meant for debugging and testing. Signed-off-by: Vincent Whitchurch Link: https://lore.kernel.org/r/20220301111831.3742383-3-vincent.whitchurch@axis.com Signed-off-by: Mark Brown --- diff --git a/drivers/regulator/virtual.c b/drivers/regulator/virtual.c index 50d2e9c..9e0abbe 100644 --- a/drivers/regulator/virtual.c +++ b/drivers/regulator/virtual.c @@ -285,8 +285,21 @@ static int regulator_virtual_probe(struct platform_device *pdev) { char *reg_id = dev_get_platdata(&pdev->dev); struct virtual_consumer_data *drvdata; + static bool warned; int ret; + if (!warned) { + warned = true; + pr_warn("**********************************************************\n"); + pr_warn("** NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE **\n"); + pr_warn("** **\n"); + pr_warn("** regulator-virtual-consumer is only for testing and **\n"); + pr_warn("** debugging. Do not use it in a production kernel. **\n"); + pr_warn("** **\n"); + pr_warn("** NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE **\n"); + pr_warn("**********************************************************\n"); + } + drvdata = devm_kzalloc(&pdev->dev, sizeof(struct virtual_consumer_data), GFP_KERNEL); if (drvdata == NULL)