From: Pekka Paalanen <pekka.paalanen@collabora.com>
Date: Wed, 6 Nov 2019 10:07:23 +0000 (+0200)
Subject: ivi-shell: fix init error path
X-Git-Tag: upstream/9.0.0~266
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=d2b9b5d1ccff5934f2c75ca2dad64d6ff8f4f790;p=platform%2Fupstream%2Fweston.git

ivi-shell: fix init error path

This was forgetting to remove the compositor destroy listener if init failed,
which would lead to use-after-free on compositor tear-down. Found by
inspection.

Signed-off-by: Pekka Paalanen <pekka.paalanen@collabora.com>
---

diff --git a/ivi-shell/ivi-shell.c b/ivi-shell/ivi-shell.c
index 244290b8..99431d0b 100644
--- a/ivi-shell/ivi-shell.c
+++ b/ivi-shell/ivi-shell.c
@@ -649,6 +649,7 @@ err_desktop:
 	weston_desktop_destroy(shell->desktop);
 
 err_shell:
+	wl_list_remove(&shell->destroy_listener.link);
 	free(shell);
 
 	return IVI_FAILED;