From: Wei Yongjun Date: Fri, 22 Mar 2013 15:11:00 +0000 (-0600) Subject: cciss: fix invalid use of sizeof in cciss_find_cfgtables() X-Git-Tag: v3.12-rc1~1140^2~5 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=d2b805d89510737ea80c1469f854a16480d19778;p=kernel%2Fkernel-generic.git cciss: fix invalid use of sizeof in cciss_find_cfgtables() sizeof() when applied to a pointer typed expression gives the size of the pointer, not that of the pointed data. Signed-off-by: Wei Yongjun Acked-by: scameron@beardog.cce.hp.com Signed-off-by: Jens Axboe --- diff --git a/drivers/block/cciss.c b/drivers/block/cciss.c index ade58bc..1c1b8e5 100644 --- a/drivers/block/cciss.c +++ b/drivers/block/cciss.c @@ -4206,7 +4206,7 @@ static int cciss_find_cfgtables(ctlr_info_t *h) if (rc) return rc; h->cfgtable = remap_pci_mem(pci_resource_start(h->pdev, - cfg_base_addr_index) + cfg_offset, sizeof(h->cfgtable)); + cfg_base_addr_index) + cfg_offset, sizeof(*h->cfgtable)); if (!h->cfgtable) return -ENOMEM; rc = write_driver_ver_to_cfgtable(h->cfgtable);