From: Matthew Barnes <mbarnes@redhat.com>
Date: Mon, 7 May 2007 19:26:48 +0000 (+0000)
Subject: Nullify 'new' after dropping its reference, so that we return NULL.
X-Git-Tag: upstream/3.7.4~5790
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=d2b3c11a38fea0f7ec8c37955026f4d0b6d7be96;p=platform%2Fupstream%2Fevolution-data-server.git

Nullify 'new' after dropping its reference, so that we return NULL.

2007-05-07  Matthew Barnes  <mbarnes@redhat.com>

	* libedataserver/e-source-group.c (e_source_group_new_from_xmldoc):
	Nullify 'new' after dropping its reference, so that we return NULL.


svn path=/trunk/; revision=7730
---

diff --git a/ChangeLog b/ChangeLog
index 290d210..ddc4db6 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,10 @@
 2007-05-07  Matthew Barnes  <mbarnes@redhat.com>
 
+	* libedataserver/e-source-group.c (e_source_group_new_from_xmldoc):
+	Nullify 'new' after dropping its reference, so that we return NULL.
+
+2007-05-07  Matthew Barnes  <mbarnes@redhat.com>
+
 	* docs/reference/camel/Makefile.am:
 	Remove reference to nonexistent libutil.la.
 
diff --git a/libedataserver/e-source-group.c b/libedataserver/e-source-group.c
index b14053f..dd97710 100644
--- a/libedataserver/e-source-group.c
+++ b/libedataserver/e-source-group.c
@@ -229,6 +229,7 @@ e_source_group_new_from_xmldoc (xmlDocPtr doc)
 
 		if (new_source == NULL) {
 			g_object_unref (new);
+			new = NULL;
 			goto done;
 		}
 		e_source_group_add_source (new, new_source, -1);