From: Kyle Tso <kyletso@google.com>
Date: Tue, 14 Jul 2020 03:34:53 +0000 (+0800)
Subject: usb: typec: tcpm: Error handling for tcpm_register_partner_altmodes
X-Git-Tag: v5.10.7~1952^2~74
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=d25d61be6bed44d3a5b7050836e6df602bf3d6ba;p=platform%2Fkernel%2Flinux-rpi.git

usb: typec: tcpm: Error handling for tcpm_register_partner_altmodes

typec_partner_register_altmode returns ERR_PTR. Reset the pointer
altmode to NULL on failure.

Signed-off-by: Kyle Tso <kyletso@google.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Link: https://lore.kernel.org/r/20200714033453.4044482-3-kyletso@google.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c
index 82b19eb..a6d4b03 100644
--- a/drivers/usb/typec/tcpm/tcpm.c
+++ b/drivers/usb/typec/tcpm/tcpm.c
@@ -1061,9 +1061,11 @@ static void tcpm_register_partner_altmodes(struct tcpm_port *port)
 	for (i = 0; i < modep->altmodes; i++) {
 		altmode = typec_partner_register_altmode(port->partner,
 						&modep->altmode_desc[i]);
-		if (!altmode)
+		if (IS_ERR(altmode)) {
 			tcpm_log(port, "Failed to register partner SVID 0x%04x",
 				 modep->altmode_desc[i].svid);
+			altmode = NULL;
+		}
 		port->partner_altmode[i] = altmode;
 	}
 }