From: Matthew Garrett Date: Tue, 5 Oct 2010 18:54:06 +0000 (-0400) Subject: IPS driver: Fix limit clamping when reducing CPU power X-Git-Tag: v3.0~3167^2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=d24a9da573444ab4aff38af2f4a0da07408ff491;p=platform%2Fkernel%2Flinux-amlogic.git IPS driver: Fix limit clamping when reducing CPU power Values here are in internal units rather than Watts, so we shouldn't perform any conversion. Signed-off-by: Matthew Garrett --- diff --git a/drivers/platform/x86/intel_ips.c b/drivers/platform/x86/intel_ips.c index 4b3ecde..c44a5e8 100644 --- a/drivers/platform/x86/intel_ips.c +++ b/drivers/platform/x86/intel_ips.c @@ -415,7 +415,7 @@ static void ips_cpu_lower(struct ips_driver *ips) new_limit = cur_limit - 8; /* 1W decrease */ /* Clamp to SKU TDP limit */ - if (((new_limit * 10) / 8) < (ips->orig_turbo_limit & TURBO_TDP_MASK)) + if (new_limit < (ips->orig_turbo_limit & TURBO_TDP_MASK)) new_limit = ips->orig_turbo_limit & TURBO_TDP_MASK; thm_writew(THM_MPCPC, (new_limit * 10) / 8);