From: Yang Tse <yangsita@gmail.com>
Date: Tue, 29 Jul 2008 02:26:21 +0000 (+0000)
Subject: Tests done using 'aclocal -I m4' in buildconf and 'ACLOCAL_AMFLAGS = -I m4
X-Git-Tag: upstream/1.10.0~768
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=d20656e947f124db5a44c00ae9ed9e23f0af38f3;p=platform%2Fupstream%2Fc-ares.git

Tests done using 'aclocal -I m4' in buildconf and 'ACLOCAL_AMFLAGS = -I m4
in top Makefile.am triggered a problem that prevented aclocal from running
successfully on SunOS 5.10 with GNU m4 1.4.5 and GNU Autoconf 2.61

A tarball which reproduces mentioned problem is the one dated July-28-2008
http://cool.haxx.se/curl-daily/curl-7.19.0-20080728.tar.gz

We actually don't need all the bells and whistles that the above mechanism
provides. We only need to include our m4/reentrant.m4 file in acinclude.m4
so here we go with this simpler mechanism.
---

diff --git a/Makefile.am b/Makefile.am
index 04db9ec..a9433ab 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -1,7 +1,5 @@
 AUTOMAKE_OPTIONS = foreign
 
-ACLOCAL_AMFLAGS = -I m4
-
 lib_LTLIBRARIES = libcares.la
 
 man_MANS = $(MANPAGES)
diff --git a/acinclude.m4 b/acinclude.m4
index 18fac9a..13d1b08 100644
--- a/acinclude.m4
+++ b/acinclude.m4
@@ -2120,3 +2120,11 @@ AC_DEFUN([CARES_CHECK_GETSERVBYPORT_R], [
   fi
 ])
 
+dnl Tests done using 'aclocal -I m4' in buildconf and 'ACLOCAL_AMFLAGS = -I m4'
+dnl in top Makefile.am triggered a problem that prevented aclocal from running
+dnl successfully on SunOS 5.10 with GNU m4 1.4.5 and GNU Autoconf 2.61
+dnl We actually don't need all the bells and whistles that the above mechanism
+dnl provides. We only need to include our m4/reentrant.m4 file here.
+
+m4_include([m4/reentrant.m4])
+
diff --git a/buildconf b/buildconf
index bfaf39e..364d5a0 100755
--- a/buildconf
+++ b/buildconf
@@ -1,13 +1,5 @@
 #!/bin/sh
 
-if test -z "$ACLOCAL_FLAGS"; then
-  ACLOCAL_FLAGS="-I m4"
-else
-  ACLOCAL_FLAGS="$ACLOCAL_FLAGS -I m4"
-fi
-export ACLOCAL_FLAGS
-echo "cares buildconf: using ACLOCAL_FLAGS: $ACLOCAL_FLAGS"
-
 ${LIBTOOLIZE:-libtoolize} --copy --automake --force
 ${ACLOCAL:-aclocal} $ACLOCAL_FLAGS
 ${AUTOHEADER:-autoheader}