From: Юрий Новиков/AI Tools Lab /SRR/Assistant Engineer/삼성전자 <y.novikov@partner.samsung.com>
Date: Fri, 31 Aug 2018 15:33:20 +0000 (+0300)
Subject: Closing files in interpreter`s plugin and cpp operations (#1185)
X-Git-Tag: nncc_backup~1983
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=d20487a04cf7c7d44f9076a4ec4f4ab42665002d;p=platform%2Fcore%2Fml%2Fnnfw.git

Closing files in interpreter`s plugin and cpp operations (#1185)

Add closing of files in interpreter_plugin.cpp and cpp_operations.def. Also checking for error codes was made.

Signed-off-by: y.novikov <y.novikov@partner.samsung.com>
---

diff --git a/contrib/nnc/plugin/interpreter/interpreter_plugin.cpp b/contrib/nnc/plugin/interpreter/interpreter_plugin.cpp
index ba553fa..09555b9 100644
--- a/contrib/nnc/plugin/interpreter/interpreter_plugin.cpp
+++ b/contrib/nnc/plugin/interpreter/interpreter_plugin.cpp
@@ -139,6 +139,9 @@ TensorVariant InterpreterPlugin::loadInput(const Shape &shape)
   auto data = new char[len];
   auto rlen = fread(data, len, 1, f);
   assert(rlen == 1);
+  int is_error = fclose(f);
+  assert(is_error != EOF &&  "Can not close file!");
+  (void)is_error;
 
   return TensorVariant(shape, std::shared_ptr<char>(data, [](const char* d) { delete[] d; }), TensorVariant::DTYPE::FLOAT, sizeof(float));
 }
diff --git a/contrib/nnc/plugin/soft_backend/cpp_operations.def b/contrib/nnc/plugin/soft_backend/cpp_operations.def
index 0d07fff..aa2f76e 100644
--- a/contrib/nnc/plugin/soft_backend/cpp_operations.def
+++ b/contrib/nnc/plugin/soft_backend/cpp_operations.def
@@ -44,6 +44,9 @@ void readParameters(char *&data, size_t &len, const string &path,
   assert(hash == expectedHash);
 
   data = static_cast<char *>(mmap(NULL, len, PROT_READ, MAP_PRIVATE, fd, 0));
+  int is_error = close(fd);
+  assert(!is_error &&  "Can not close file!");
+  (void)is_error;
 }
 
 void releaseParameters(char *data, size_t len)